Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTF support for new tx types #812

Open
Dentosal opened this issue Sep 5, 2024 · 1 comment
Open

GTF support for new tx types #812

Dentosal opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@Dentosal
Copy link
Member

Dentosal commented Sep 5, 2024

From Slack:

I don't see a GTF opcode defined to get the witnessesCount, witnesses, outputs, outputsCount, inputs, and inputsCount for TransactionUpgrade, TransactionUpload, and TransactionBlob in the specs as well as transaction specific types such as subsectionIndex, subsectionsNumber, root, witnessIndex, proofSetCount, and proofSet in TransactionUpload.

This is blocking FuelLabs/sway#6500

@xgreenx
Copy link
Collaborator

xgreenx commented Sep 6, 2024

Also, it seems that we have a different getter for each type of transaction. I think we just need to have one getter for all types. And if the transaction doesn't support it, return an error like in the case of Mint transaction.

image image image image

@AurelienFT AurelienFT self-assigned this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants