-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display consistent decimals when approving transactions #1681
Open
helciofranco
wants to merge
7
commits into
master
Choose a base branch
from
hf/feat/consistent-decimals
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+68
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
helciofranco
commented
Dec 4, 2024
•
edited
Loading
edited
- Closes Needs consistent decimal configuration across screens #1675
- Closes show NFT badge in screens from wallet #1659
📷 Asset | 📷 NFT | 📷 TX |
---|---|---|
…t/consistent-decimals
helciofranco
requested review from
luizstacio,
pedronauck,
LuizAsFight,
arthurgeron,
rodrigobranas and
nelitow
as code owners
December 4, 2024 15:36
arthurgeron
reviewed
Dec 6, 2024
|
||
const assetsWithAmount: (AssetFuelAmount | null)[] = await Promise.all( | ||
params.operationsCoin.map(async (operationCoin) => { | ||
const assetCached = await assetsCache.getAsset({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be a query, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.