Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Minor Charting Tweaks for Dadbattle Erect/Nightmare, Fresh (Pico Mix) #3396

Open
2 tasks done
TJHOnGithub opened this issue Sep 20, 2024 · 1 comment · May be fixed by FunkinCrew/funkin.assets#88
Open
2 tasks done

Enhancement: Minor Charting Tweaks for Dadbattle Erect/Nightmare, Fresh (Pico Mix) #3396

TJHOnGithub opened this issue Sep 20, 2024 · 1 comment · May be fixed by FunkinCrew/funkin.assets#88
Labels
status: pending triage The bug or PR has not been reviewed yet. type: charting issue Involves the charting or placement of notes for a level.

Comments

@TJHOnGithub
Copy link

Issue Checklist

  • I have properly named the enhancement
  • I have checked the issues/discussions pages to see if the enhancement has been previously suggested

What is your suggestion, and why should it be implemented?

theres a few charting issues present in dadbattle erect and fresh pico, fresh pico for instance has 4 missing notes on daddy dearests side during his fifth turn, dadbattle erect has a missing note on his third turn that is instead covered by an up note that goes on for too long, theres also a few inconsistencies present with a LOT of erect/nightmare charts as well, for example, all of dds "repeated" turns in dadbattle are charted differently from the first ones for some reason (please ignore the roughness of image 2)
dadbattle mistake
quick patch idea
@TJHOnGithub TJHOnGithub added status: pending triage The bug or PR has not been reviewed yet. type: enhancement Provides an enhancement or new feature. labels Sep 20, 2024
@EliteMasterEric EliteMasterEric added type: charting issue Involves the charting or placement of notes for a level. and removed type: enhancement Provides an enhancement or new feature. labels Sep 22, 2024
@Hundrec Hundrec linked a pull request Oct 24, 2024 that will close this issue
Open
@Hundrec
Copy link
Contributor

Hundrec commented Oct 24, 2024 •
edited
Loading

I've started a PR in funkin.assets to add the missing note in Section 12 of DadBattle Erect/Nightmare, but the other issues you mentioned seem fine to me.

Fresh (Pico Mix) applies an echo to almost all of Dad's vocals, so the charter didn't chart any of them.
DadBattle Erect's chart being different in Dad's repeated sections seems like a stylistic choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: pending triage The bug or PR has not been reviewed yet. type: charting issue Involves the charting or placement of notes for a level.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing note to DadBattle Erect and Nightmare Hundrec/funkin.assets
3 participants
@EliteMasterEric @TJHOnGithub @Hundrec