Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning min version on co-versioned packages #159

Open
jamesbraza opened this issue Dec 18, 2024 · 0 comments
Open

Pinning min version on co-versioned packages #159

jamesbraza opened this issue Dec 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jamesbraza
Copy link
Collaborator

As of fhaviary==0.8.1 at https://github.com/Future-House/aviary/blob/v0.8.1/pyproject.toml#L33-L34 the following are equivalent:

pip install fhaviary[gsm8k]==0.8.1
pip install fhaviary==0.8.1 aviary.gsm8k

Then #51 made it so aviary.gsm8k<0.8.2 is incompatible with fhaviary>=0.8.2.

We need to change the way we version within the gsm8k and hotpotqa extras so the following are equivalent:

pip install fhaviary[gsm8k]>=0.8.2
pip install fhaviary>=0.8.2 aviary.gsm8k>=0.8.2
@jamesbraza jamesbraza added the bug Something isn't working label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant