redundant advisory lock (already locking in private method)

G-Research · Nov 27, 2024 · 31d011d · 31d011d
1 parent d25b651
commit 31d011d
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/app/lib/clients/vault/policy.rb b/app/lib/clients/vault/policy.rb
@@ -13,18 +13,14 @@ def rotate_token
       def assign_entity_policy(identity, policy_name)
         sub = identity.sub
         email = identity.email
-        Domain.with_advisory_lock(sub) do
-          put_entity(sub, [ policy_name ])
-          put_entity_alias(sub, email, "oidc")
-        end
+        put_entity(sub, [ policy_name ])
+        put_entity_alias(sub, email, "oidc")
       end
 
       def assign_groups_policy(groups, policy_name)
         groups.each do |group|
-          Domain.with_advisory_lock(group) do
-            put_group(group, [ policy_name ])
-            put_group_alias(group, group, "oidc")
-          end
+          put_group(group, [ policy_name ])
+          put_group_alias(group, group, "oidc")
         end
       end