From c791cfa129fdc180d7def7dfb435010c8052fc60 Mon Sep 17 00:00:00 2001 From: Patrick Connolly Date: Thu, 29 Sep 2022 13:26:23 +0100 Subject: [PATCH 1/2] Temporarily disabled docker layer caching in github action. --- .github/workflows/e2e-tests.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 6675a7dcaf8..3c03effae0e 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -47,6 +47,10 @@ jobs: # This uses GitHub Action cache for docker container layers # See: https://github.com/marketplace/actions/docker-layer-caching - uses: satackey/action-docker-layer-caching@v0.0.11 + # Disable for now, to avoid storage space error. + # #TODO investigate how to run this without error. + # See: https://github.com/GCTC-NTGC/gc-digital-talent/issues/4035#issuecomment-1261116699 + if: false # Ignore a failure of this step and avoid terminating the job. continue-on-error: true # By default, this cache is keyed to the workflow name. We ar From 3df83afb6b4e6ec5c0e9e82888ebdcbce2296015 Mon Sep 17 00:00:00 2001 From: Patrick Connolly Date: Thu, 29 Sep 2022 14:29:55 +0100 Subject: [PATCH 2/2] Fully removed docker layer caching. --- .github/workflows/e2e-tests.yml | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 3c03effae0e..a58e3263c71 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -44,22 +44,8 @@ jobs: - name: Checkout uses: actions/checkout@v3.0.2 - # This uses GitHub Action cache for docker container layers - # See: https://github.com/marketplace/actions/docker-layer-caching - - uses: satackey/action-docker-layer-caching@v0.0.11 - # Disable for now, to avoid storage space error. - # #TODO investigate how to run this without error. - # See: https://github.com/GCTC-NTGC/gc-digital-talent/issues/4035#issuecomment-1261116699 - if: false - # Ignore a failure of this step and avoid terminating the job. - continue-on-error: true - # By default, this cache is keyed to the workflow name. We ar - # setting a shared key for the docker cache to be shared - # across multiple workflows. - with: - key: docker-{hash} - restore-keys: | - docker- + # We no longer user docker layer caching as it made runs take longer. + # See: https://github.com/satackey/action-docker-layer-caching/issues/305 - name: Serve app via docker-compose # Need to include --build as we're caching layers.