❓ Do we need objectsToSortedOptions?

[mnigh]

Isn't objectsToSortedOptions doing the same thing as sortOptions? Can we get rid of objectsToSortedOptions and its references?

objectsToSortedOptions

gc-digital-talent/packages/forms/src/utils.ts

Lines 152 to 180 in bade5dc

	/**
	* Maps a list of objects to sorted options
	* @param objects An array of objects with an id and name property
	* @param intl The current intl of the page
	* @returns An array of sorted options
	*/
	export const objectsToSortedOptions = (
	objects: {
	id: Scalars["ID"];
	name: LocalizedString;
	}[],
	intl: IntlShape,
	): { value: string; label: string }[] => {
	const locale = getLocale(intl);
	return objects
	.sort((a, b) => {
	const aName: Maybe<string> = a.name[locale];
	const bName: Maybe<string> = b.name[locale];
	if (aName && bName) {
	return aName.localeCompare(bName, locale);
	}
	return 0;
	})
	.map(({ id, name }) => ({
	value: id,
	label: name[locale] ?? intl.formatMessage(commonMessages.notFound),
	}));
	};

sortOptions

gc-digital-talent/packages/forms/src/components/Select/Select.tsx

Lines 45 to 75 in bade5dc

	function sortOptions(options: OptGroupOrOption[]) {
	const tempOptions = options.map((option: OptGroupOrOption) =>
	Object.prototype.hasOwnProperty.call(option, "options")
	? {
	label: option.label,
	options: orderBy(
	option.options,
	({ label }) =>
	isString(label)
	? label
	.normalize("NFD")
	.replace(/[\u0300-\u036f]/g, "")
	.toLocaleLowerCase()
	: label,
	"asc",
	),
	}
	: option,
	);
	return orderBy(
	tempOptions,
	({ label }) =>
	isString(label)
	? label
	.normalize("NFD")
	.replace(/[\u0300-\u036f]/g, "")
	.toLocaleLowerCase()
	: label,
	"asc",
	);
	}

[tristan-orourke]

They're doing similar work, but on differently-shaped objects. Maybe they could be consolidated into a more general function, but I'm not sure its worth it.