Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Can't resolve '@emotion/is-prop-valid' when running storybook #10143

Closed
1 task
mnigh opened this issue Apr 19, 2024 · 2 comments
Closed
1 task

🛠️ Can't resolve '@emotion/is-prop-valid' when running storybook #10143

mnigh opened this issue Apr 19, 2024 · 2 comments
Labels
tooling Tooling, automation and CI to support development.

Comments

@mnigh
Copy link
Contributor

mnigh commented Apr 19, 2024 •
edited
Loading

🛠️ Tooling

Module not found: Error: Can't resolve '@emotion/is-prop-valid' when running storybook.

🦋 Expected Behaviour

No warning should occur.

📋 Steps to Reproduce

  1. pnpm storybook
  2. Observe warning during build

📸 Screenshot

Screen Shot 2024-04-19 at 15 03 46

✅ Acceptance Criteria

A set of assumptions which, when tested, verify that the bug was addressed.

  • no warning of Module not found: Error: Can't resolve '@emotion/is-prop-valid' when building storybook
@mnigh mnigh added the debt Refactor or improve existing code. label Apr 19, 2024
@mnigh mnigh moved this to 🏗 In progress in GC Digital Talent Apr 19, 2024
@mnigh mnigh self-assigned this Apr 19, 2024
@mnigh mnigh removed the status in GC Digital Talent Apr 19, 2024
@mnigh mnigh removed their assignment Apr 19, 2024
@mnigh mnigh changed the title ♻️ Reduce size of motion component ♻️ Can't resolve '@emotion/is-prop-valid' when running storybook Apr 19, 2024
@mnigh mnigh added tooling Tooling, automation and CI to support development. and removed debt Refactor or improve existing code. labels Apr 19, 2024
@mnigh mnigh changed the title ♻️ Can't resolve '@emotion/is-prop-valid' when running storybook 🛠️ Can't resolve '@emotion/is-prop-valid' when running storybook Apr 19, 2024
@mnigh
Copy link
Contributor Author

mnigh commented May 6, 2024

Can confirm this warning goes away when framer/motion is pinned on v11.0.11. This bug seems to have been introduced with v11.0.12, see motiondivision/motion#2531.

@mnigh
Copy link
Contributor Author

mnigh commented May 6, 2024

Closing this issue as this is not something we can solve (other than rolling back to an older version of framer/motion).

@mnigh mnigh closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tooling Tooling, automation and CI to support development.
Projects
GC Digital Talent
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnigh