Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add command to give back quotes #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add command to give back quotes #37

wants to merge 1 commit into from

Conversation

youben11
Copy link
Member

Fixes #23

@youben11 youben11 requested a review from akram09 January 29, 2022 11:40
@mhdcodes
Copy link

Give the man what he deserves 👕

akram09
akram09 approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@akram09 akram09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to use an external API for getting quotes, the case for advice is that we didn't find suitable advice set with respectful advice.
Otherwise I think this is legitimate 👍

@mhdcodes
Copy link

mhdcodes commented Feb 1, 2022

@akram09 I think https://quotes.rest/ can do the trick.

nice thing is it has a way to fetch private quotes. so instead of csv file you create your own private set of quotes. and then fetch em later when requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akram09 akram09 akram09 approved these changes

@mhdcodes mhdcodes mhdcodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature/Daily Quotes
3 participants
@youben11 @mhdcodes @akram09