Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2주차 - 임건영 #20

Merged
merged 36 commits into from
Jan 11, 2023
Merged

2주차 - 임건영 #20

merged 36 commits into from
Jan 11, 2023

Conversation

ImKunYoung
Copy link
Member

Closes #10

@ImKunYoung
initial commit
f36fd39
@ImKunYoung
test: Add a test case for plus method
21299f4
@ImKunYoung
docs: Add Document of test statement
7c06a4d
@ImKunYoung
feat: Add plus
dc68c5f
@ImKunYoung
style: Remove line
7fb53ec
@ImKunYoung
docs: Document test result
4d8e302
@ImKunYoung
fix: Fix return val
8fab0a1
@ImKunYoung
docs: Document test result
857daf5
@ImKunYoung
feat: Add Calculator Plus
e679394
@ImKunYoung
refactor: Change file name
c0c80e2
@ImKunYoung
test: Add test case when all rules are met
474f33a
@ImKunYoung
test: Add test case Not meeting all conditions
3059c4d
@ImKunYoung
fix: fix not meeting all conditions
808975d
@ImKunYoung
test: Add additional not meeting conditions
a26c252
@ImKunYoung
test: Add meets other criteria except for number then normal
8844b05
@ImKunYoung
fix: Fix meets other criteria except for number then normal
9816dec
@ImKunYoung
refactor: Extract methods from meter
3783d4f
@ImKunYoung
test: Add test case when null input
8286bac
@ImKunYoung
fix: Fix when null input case
9862679
@ImKunYoung
test: Add test case when empty input
e77329f
@ImKunYoung
test: Add test case when meets other criteria except for uppercase th…
34fe8b2 
…en normal
@ImKunYoung
fix: Fix when meets other criteria except for uppercase then normal
dbf7664
@ImKunYoung
test: Add test case when meets only length criteria then weak
bd1c6e2
@ImKunYoung
fix: fix to pass meetsOnlyLengthCriteria_Then_Weak
00852f4
@ImKunYoung
test: Add test case when meets only number criteria then weak
179c519
@ImKunYoung
fix: Fix to pass meetsOnlyNumCriteria_Then_Weak case
95aba9e
@ImKunYoung
test: Add test case when meets only uppercase criteria then weak
54c61af
@ImKunYoung
fix: Fix to pass meetsOnlyUppercaseCriteria_Then_Weak
cd5f021
@ImKunYoung
refactor: Refactoring to reduce if - clause
f1d95f6
@ImKunYoung
test: Add test case when meets no criteria then invalid
af23f32
@ImKunYoung ImKunYoung requested review from hou27 and rladuswl January 11, 2023 04:23
@ImKunYoung ImKunYoung self-assigned this Jan 11, 2023
hou27
hou27 approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@hou27 hou27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!

@hou27 hou27 merged commit ace8687 into main Jan 11, 2023
@ImKunYoung ImKunYoung linked an issue Jan 12, 2023 that may be closed by this pull request
3주차 - 테스트 코드 작성 순서 - 임건영 #24
Closed
4 tasks
@hou27 hou27 added this to the GDSC MJU 1기 TDD 스터디 milestone Jan 15, 2023
@ImKunYoung ImKunYoung linked an issue Jan 22, 2023 that may be closed by this pull request
4주차 - TDD ∙ 기능 명세 ∙ 설계 - 임건영 #43
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hou27 hou27 hou27 approved these changes

@rladuswl rladuswl Awaiting requested review from rladuswl

Assignees

@ImKunYoung ImKunYoung

Labels
None yet
Projects
None yet
Milestone
GDSC MJU 1기 TDD 스터디
2 participants
@ImKunYoung @hou27