Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate emails for fines #143

Closed
rinkp opened this issue Jan 20, 2024 · 2 comments
Closed

Avoid duplicate emails for fines #143

rinkp opened this issue Jan 20, 2024 · 2 comments

Comments

@rinkp
Copy link
Member

rinkp commented Jan 20, 2024

Currently, users that have been fined will receive both an email

  • that they have been fined
  • that they will be fined next week if they don't top up

While I think it is important that users are reminded of a negative balance often, I think this might be a bit superfluous and I would suggest not sending the latter if you just sent the former (i.e. added a fine the past day

Moreover, sending two emails in a short while may cause behaviour where the spam filter of the recipient is checking whether it will receive more email from GEWIS for determining the likelihood of spam and we actually send them these emails.

Additionally, you might want to consider sending the second email even if you don't really add fines, such as during the exam week.

@CodeNamedRobin
Copy link
Contributor

Personally, I think this might be a better idea to implement in the frontend? Both notify and handout endpoints have userIds parameters in their requests. How I could keep track of if users got an email recently (probably same day?) I don't really know, but that's a problem for later.

@Yoronex
Copy link
Member

Yoronex commented Oct 18, 2024

We leave this issue to the frontend, as the BACPM is the one giving the list of users to notify to the backend. GEWIS/sudosos-frontend#361

@Yoronex Yoronex closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants