Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geographic extent of data #17

Open
stufraser1 opened this issue Dec 1, 2020 · 4 comments
Open

Geographic extent of data #17

stufraser1 opened this issue Dec 1, 2020 · 4 comments

Comments

@stufraser1
Copy link
Member

Ensure data extent is included for all data (geom available at data point level) dataset level extent not available?

@stufraser1
Copy link
Member Author

@mamadio @ConnectedSystems have we accounted for inclusion of data extent and does it make sense for this to be a metadata field if storing the file separately? The extent is provided already in the tif/shp metadata and gets loaded to e.g. QGIS, but do we require it in the schema itself, in addition to ISO3a code

@ConnectedSystems
Copy link
Collaborator

ConnectedSystems commented Feb 12, 2021

Yes, the extent is included for Hazard, Exposure, and Loss.

In the last iteration of the schema I implemented with SQLAlchemy, for example, the the_geom field for hazard.EventSet holds a polygon which holds the union of all extents for a submitted dataset.

The proof-of-concept I demoed had a tentative working implementation for the hazard schema (see here for code if curious). This handles import, assuming 1 metadata file per raster, assumed to be a tiff in this case but easy to extend to some other formats.

Checking with @matamadio Vulnerability is a special case which is why the field does not exist for the Vulnerability component.

But should it be a required element of the Schema itself? Probably not. Discussing it with @matamadio, it does seem more an implementation detail; to support map preview, search/filtering, etc.

@stufraser1
Copy link
Member Author

stufraser1 commented Feb 12, 2021 via email

@matamadio
Copy link

matamadio commented Feb 12, 2021

Well the extent is not currently implemented in MVP, as BBOX coordinates are not great by themselves but useful to display map extent preview, which we agreed is not part of MVP.
Should we look to add it on MVP based on PoC code, or look forward for having this in REdesign?

V does not have spatial data

I tend to agree, but cannot exclude exceptions (e.g a damage factor map used to multiply hazard).

applicability of the V relationship is capture in ISO codes. This is a point to consider though (related to putting ISO code in contribution field). A V curve may be applicable to multiple countries, beyond the country to which the project relates. We
need to make sure we can handle this in the revision to contribution table / ISO fields.

Yes, in fact I kept the fcore.country_iso applicability; the contribution.geo_coverage refers to country the model was produced for; the fcore.country_iso refers to all countries where the model can be applied to. This needs to be well explained in the guide.

@matamadio matamadio changed the title data extent - ged4all/loss Geographic extent of data Apr 28, 2021
@matamadio matamadio transferred this issue from GFDRR/rdl-data Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants