Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating labels for SvgFeatureRenderer #175

Closed
rbuels opened this issue Mar 4, 2019 · 10 comments
Closed

floating labels for SvgFeatureRenderer #175

rbuels opened this issue Mar 4, 2019 · 10 comments
Labels
size medium not trivial

Comments

@rbuels
Copy link
Contributor

rbuels commented Mar 4, 2019

svgfeaturerenderer labels were added in #159, but now we need to make them "float" like they do in JBrowse 1.

@rbuels rbuels added the size medium not trivial label Jun 21, 2019
@cmdcolin
Copy link
Collaborator

cmdcolin commented Feb 1, 2020

Random note: Floating labels on canvas may be difficult? JB1 does have floating canvas labels

@cmdcolin
Copy link
Collaborator

cmdcolin commented Feb 6, 2020

Could do the label rendering on the client side as a way of combatting the "floating labels may be difficult"

@rbuels rbuels closed this as completed Feb 21, 2020
@cmdcolin
Copy link
Collaborator

Any reason why this was closed? It is still an issue

@cmdcolin cmdcolin reopened this Aug 25, 2020
@cmdcolin
Copy link
Collaborator

I think we do need some solution for floating or always-visible feature labels so I'm re-opening this

@cmdcolin
Copy link
Collaborator

Note that a very compact view of features a la UCSC can be quite nice
Screenshot from 2020-08-25 19-58-12

@cmdcolin
Copy link
Collaborator

Note that we had discussed that perhaps SvgFeatureRenderer in particular might be revamped into a canvas/svg type thing so maybe not specifically targetting SVG. Attempts at this should maybe be discussed

@elliothershberg
Copy link
Member

I think this feature would definitely make the nexstrain demo #1616 more compelling if we have implemented this feature.

@rbuels
Copy link
Contributor Author

rbuels commented Jan 29, 2021

We probably will want to make the label moving something that only happens on the main thread, without doing a full rerender. We might need to add some kind of method that renderers can call for doing partial client-side re-renders.

@cmdcolin
Copy link
Collaborator

The "rendering" component can be an observer react component which might give it enough access to help it fix

@rbuels
Copy link
Contributor Author

rbuels commented Mar 5, 2021

closing in favor of doing #674 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size medium not trivial
Projects
None yet
Development

No branches or pull requests

3 participants