-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
floating labels for SvgFeatureRenderer #175
Comments
Random note: Floating labels on canvas may be difficult? JB1 does have floating canvas labels |
Could do the label rendering on the client side as a way of combatting the "floating labels may be difficult" |
Any reason why this was closed? It is still an issue |
I think we do need some solution for floating or always-visible feature labels so I'm re-opening this |
Note that we had discussed that perhaps SvgFeatureRenderer in particular might be revamped into a canvas/svg type thing so maybe not specifically targetting SVG. Attempts at this should maybe be discussed |
I think this feature would definitely make the nexstrain demo #1616 more compelling if we have implemented this feature. |
We probably will want to make the label moving something that only happens on the main thread, without doing a full rerender. We might need to add some kind of method that renderers can call for doing partial client-side re-renders. |
The "rendering" component can be an observer react component which might give it enough access to help it fix |
closing in favor of doing #674 instead |
svgfeaturerenderer labels were added in #159, but now we need to make them "float" like they do in JBrowse 1.
The text was updated successfully, but these errors were encountered: