-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow ups to multi-variant rendering #4712
Comments
example of showing larger scale SVs in a multi-variant type way, this example with inversion polymorphism (from https://genomebiology.biomedcentral.com/articles/10.1186/s13059-023-02919-8/figures/1) |
could look into more hprc data from |
Any workarounds to display polyploid variant calls so far? I picture it to myself as a heatmap with proportions of ALT calls in each cell (e.g. 0/0/0/1 is at 25% on the color scale). Obviously not applicable to multiallelic sites but they are a headache anyway. |
this is a great idea. I'll see what i could do to try something like that. if you're aware of any good polyploid data to look at, let me know, i think i have some i stumbled on or i can make some synthetic data. also, indeed, the code has thus far not done any handling of multi-allelic sites either, sticking to just 4 colors 0/0 (ref, grey) 0/1 (het, teal) and 1/1 (hom, blu) and "other" (purple) |
Thanks for the quick reply! We have diploid/tetraploid mix data at hand, it's not published yet but we can share it if needed. (Publishing it is exactly why I started looking into the capabilities of Jbrowse2 😉 ) |
that's awesome. I believe I saw a talk from your group at PAG just last week! feel free to email if interested, especially if it has mixed ploidy would be curious, but might be able to find synthetic data too |
@taprs I did a little work on trying to more properly handle both phased variants and polyploid in this PR if you are using the web version, you can get the branch build with e.g. if you have phased variants, it has some particular interestingness perhaps because it can split out each haplotypes into a new row example with a trio vcf |
Thanks for the news! I set out to test it and caught an error when trying to display a random VCF region in matrix mode (default variant mode is fine, and "regular" multivariant mode does not render tetraploid samples). Here is the stack trace:
I set up the server like this: jbrowse create --branch polyploid heatmap_test
jbrowse add-assembly ./NT1_220222.fasta --load symlink -n NT1 --out heatmap_test
jbrowse add-track ./Eur_lyrata_sc1.vcf.gz --load symlink --out heatmap_test
cd heatmap_test
npx serve -S . I can send you the genome + the VCF file link via email this week. I get no error when I display them using the main branch, but understand that this VCF might be special in a few ways:
Cheers, |
interesting, i would be curious to see the VCF. that is basically completely failing to parse the genotypes out of the vcf if so. if you can show just like a single line, i might be able to extrapolate, but potentially might need the whole vcf also (also big thanks for testing out the pre-release) |
Sure, here are some 20 VCF lines stripped from the region shown in the screenshot. |
Thanks for posting this @taprs I couldn't reproduce that error so maybe still gotta look a little more, if you have the full vcf can check that out Random thing: I noticed that there are a lot of lines where no "ALT", or ALT is just a "." I have not seen that much before. The VCF spec says that this means the ALT is "MISSING" (section 1.6.1) https://samtools.github.io/hts-specs/VCFv4.5.pdf
|
@taprs I did an update to the code and it has a number of improvements, potentially a fix for that crash also |
can get it with
... pending a new release soon |
Yes, the update fixed the VCF display issue I had, thanks a ton! It was weird because the error was gone if I sliced the vcf file... As for the "missing" ALT values, we use them to have invariant sites present in the VCF and to distinguish them from sites with no data. This is useful for some popgen stuff. |
[1]
done
handle polyploid (ALT's more than 0/0,1/0,1/1) betterhide colored boxesadd mouseoverrender phase sets as a random coloradd ability to configure metadata better for multivariant. currently requires using the bulk editor<-- samplesTsvThe text was updated successfully, but these errors were encountered: