Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test #4738

Open
cmdcolin opened this issue Dec 20, 2024 · 2 comments
Open

Flaky test #4738

cmdcolin opened this issue Dec 20, 2024 · 2 comments

Comments

@cmdcolin
Copy link
Collaborator

this commit was docs only but produced a failing test 4f0eed6

Summary of all failing tests
FAIL products/jbrowse-react-linear-genome-view/src/JBrowseLinearGenomeView/JBrowseLinearGenomeView.test.tsx
  ● <JBrowseLinearGenomeView /> renders successfully

    expect(received).toMatchSnapshot()

    Snapshot name: `<JBrowseLinearGenomeView /> renders successfully 1`

    - Snapshot  - 1
    + Received  + 1

    @@ -247,11 +247,11 @@
                                  aria-expanded="false"
                                  aria-invalid="false"
                                  autocapitalize="none"
                                  autocomplete="off"
                                  class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedEnd MuiAutocomplete-input MuiAutocomplete-inputFocused css-13meb6w-MuiInputBase-input-MuiOutlinedInput-input"
    -                             id=":r0:"
    +                             id=":r2:"
                                  placeholder="Search for location"
                                  role="combobox"
                                  spellcheck="false"
                                  type="text"
                                  value="ctgA:1..40"

      87 |   )
      88 |
    > 89 |   expect(container).toMatchSnapshot()
         |                     ^
      90 | }, 40000)
@cmdcolin cmdcolin added enhancement New feature or request hard-to-reproduce and removed enhancement New feature or request labels Dec 20, 2024
@cmdcolin
Copy link
Collaborator Author

another one noted here #4776 (comment)

could potentially filter id out of snapshot but it can be a good way to see exact rendering patterns

@cmdcolin
Copy link
Collaborator Author

anothr one here https://github.com/GMOD/jbrowse-components/actions/runs/12892234696/attempts/1

"FAIL products/jbrowse-web/src/tests/NcbiAliasAdapter.test.tsx
  ✕ ncbi config (1212 ms)

  ● ncbi config

    expect(received).toMatchSnapshot()

    Snapshot name: `ncbi config 1`

    - Snapshot  - 9
    + Received  + 1

    @@ -90,11 +90,11 @@
            </text>
          </g>
        </svg>,
        <svg
          data-testid="svgfeatures"
    -     height="122"
    +     height="1300"
          style="display: block;"
          width="800.0241275715338"
        >
          <g>
            <line
    @@ -160,16 +160,8 @@
            <polygon
              fill="#000000"
              points="-98.1,0,-98.1,5,-101.6,2.5"
              stroke="#000000"
            />
    -       <text
    -         fill="#000000"
    -         font-size="12"
    -         x="-94.6"
    -         y="17"
    -       >
    -         DACT2
    -       </text>
          </g>
        </svg>,

we had crushed flaky tests pretty good at one point...unfortunate to see it returning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant