Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge-std & ds-test are being installed in downstream projects #68

Open
janjakubnanista opened this issue Feb 29, 2024 · 4 comments
Open

Comments

@janjakubnanista
Copy link

The problem

forge-std and ds-test are being installed in downstream projects even though they are not needed for this library. They are only used for testing so they should be marked as devDependencies instead of dependencies

The solution

The minimal solution would consist of changing dependencies to devDependencies. However, to follow the good scout rule, a little cleanup was introduced in #67:

  • Adding CI pipeline to test any changes
  • Add forge-std the foundry way
@GNSPS
Copy link
Owner

GNSPS commented Mar 8, 2024

I'm travelling but will get to this next week. 🙏 Thank you for the contribution

@janjakubnanista
Copy link
Author

@GNSPS thanks! It would help us a lot!

@janjakubnanista
Copy link
Author

@GNSPS het there! Any chance you could look into the PR? Very very very much appreciated!!!

@cawabunga
Copy link

Forcing users to install a package directly from github without real necessity is a kind of meh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants