From fc30712bcf6be22dd6fd9bb190804e3333cd316d Mon Sep 17 00:00:00 2001 From: Bobby Novak <176936850+rnovak338@users.noreply.github.com> Date: Tue, 10 Sep 2024 10:12:15 -0400 Subject: [PATCH 1/2] Add links to Zendesk/Django Admin for onboarding/offboarding docs (#4261) * Add links to Zendesk/Django Admin for onboarding/offboarding * Misplaced links for offboarding.md --- .github/ISSUE_TEMPLATE/offboarding.md | 3 ++- .github/ISSUE_TEMPLATE/onboarding.md | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/offboarding.md b/.github/ISSUE_TEMPLATE/offboarding.md index 4657d66b6c..f18d732bb8 100644 --- a/.github/ISSUE_TEMPLATE/offboarding.md +++ b/.github/ISSUE_TEMPLATE/offboarding.md @@ -16,7 +16,8 @@ assignees: '' - [ ] Remove from the private channels #oros-fac-private and #fac-helpdesk in Slack (“/remove @[person]”) - [ ] Remove from active Figma projects - [ ] Remove from Mural -- [ ] Remove from Zendesk +- [ ] Remove from Zendesk [here](https://fac-gov.zendesk.com/admin/people/team/members). +- [ ] Remove from the list of staff users in the Django Admin app [here](https://app.fac.gov/admin/users/staffuser/). - [ ] Check for and remove admin access in the FAC application: this may include designated permissions and/or checked-in API access ([for example](https://github.com/GSA-TTS/FAC/blob/fb0e7bdf1cb1807291e6b6eef068e97b4574078c/backend/support/api/admin_api_v1_1_0/create_access_tables.sql#L21)) ## For GitHub contributors diff --git a/.github/ISSUE_TEMPLATE/onboarding.md b/.github/ISSUE_TEMPLATE/onboarding.md index 5bbc345f10..86b23a05d6 100644 --- a/.github/ISSUE_TEMPLATE/onboarding.md +++ b/.github/ISSUE_TEMPLATE/onboarding.md @@ -86,3 +86,7 @@ Note: If you're not able to do any of these yourself, you're still responsible f - [ ] Make them Owner of [the various Google Groups in the project README](https://docs.google.com/document/d/1g8nYqYS_ifFlZB-DBgfeSoJRMB__EqWsmLnacyk-bDI/edit#heading=h.81zynabayrrg) - [ ] Add them to [the FAC-admins team in GitHub](https://github.com/orgs/GSA-TTS/teams/fac-admins/members) and make them a Maintainer. - [ ] Also give them the `Maintainer` role in [the FAC-team team in GitHub](https://github.com/orgs/GSA-TTS/teams/fac-team/members). + +**For helpdesk, also...** +- [ ] Add them to the list of staff users for [Django Admin](https://app.fac.gov/admin/users/staffuser/). +- [ ] Give them access to the [Help Desk](https://fac-gov.zendesk.com/admin/people/team/members) as a team member. From 5b73f02dcb1383223f3313976408ea762360ec4c Mon Sep 17 00:00:00 2001 From: Bobby Novak <176936850+rnovak338@users.noreply.github.com> Date: Tue, 10 Sep 2024 10:53:38 -0400 Subject: [PATCH 2/2] Update zero-state default values (#4260) Previously, `None` was being passed. This would actually type out `"None"` on the input fields when adding a new SAC access. This change keeps the blank fields. --- backend/audit/views/manage_submission_access.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backend/audit/views/manage_submission_access.py b/backend/audit/views/manage_submission_access.py index fc24a62879..72100102ce 100644 --- a/backend/audit/views/manage_submission_access.py +++ b/backend/audit/views/manage_submission_access.py @@ -144,8 +144,8 @@ def get_user_role_management_context(self, sac): "friendly_role": None, "auditee_uei": sac.general_information["auditee_uei"], "auditee_name": sac.general_information.get("auditee_name"), - "certifier_name": None, - "email": None, + "certifier_name": "", + "email": "", "report_id": sac.report_id, "errors": [], }