Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Workbook Version #2514

Closed
Tracked by #2511
sambodeme opened this issue Oct 16, 2023 · 0 comments · Fixed by #2651
Closed
Tracked by #2511

Check Workbook Version #2514

sambodeme opened this issue Oct 16, 2023 · 0 comments · Fixed by #2651
Assignees
@sambodeme
Labels
eng

Comments

@sambodeme
Copy link
Contributor

sambodeme commented Oct 16, 2023 •
edited
Loading

Add a validation check for workbook versions.
As per team discussion, the logic here will be a no-op until FAC is ready to start excluding specific versions
@sambodeme sambodeme mentioned this issue Oct 16, 2023
Open
@sambodeme sambodeme added this to FAC Oct 17, 2023
@github-project-automation github-project-automation bot moved this to Triage in FAC Oct 17, 2023
@sambodeme sambodeme added the eng label Oct 17, 2023
@sambodeme sambodeme moved this from Triage to Available in FAC Oct 17, 2023
sambodeme added a commit that referenced this issue Oct 30, 2023
@sambodeme
#2514 Added placeholder code for workbook version check
c340a92
@sambodeme sambodeme mentioned this issue Oct 30, 2023
Merged
14 tasks
@sambodeme sambodeme linked a pull request Oct 30, 2023 that will close this issue
#2514 Added placeholder code for workbook version check #2651
Merged
14 tasks
@sambodeme sambodeme moved this from Available to In Progress in FAC Oct 30, 2023
@sambodeme sambodeme self-assigned this Oct 30, 2023
sambodeme added a commit that referenced this issue Oct 31, 2023
@sambodeme
#2514 Switched WB version from formula to value to unblock failing un…
f288796 
…it tests
sambodeme added a commit that referenced this issue Oct 31, 2023
@sambodeme
#2514 Code cleaning
0a8b6e7
sambodeme added a commit that referenced this issue Oct 31, 2023
@sambodeme
#2514 Regenerate workbooks
933bdb1
sambodeme added a commit that referenced this issue Oct 31, 2023
@sambodeme
#2514 Updated workbook version
bc37799
sambodeme added a commit that referenced this issue Oct 31, 2023
@sambodeme
#2514 Enforcing version control
479cc3e
sambodeme added a commit that referenced this issue Oct 31, 2023
@sambodeme
#2514 Linting
bdfd08e
github-merge-queue bot pushed a commit that referenced this issue Nov 3, 2023
@sambodeme
#2514 Added placeholder code for workbook version check (#2651)
0362ae3 
* #2460 Just renaming

* #2460 Removed logic that transforms individual named range into string

* #2460 Added logic to turn all named ranges into stripped string + logic to turn specific named ranges into integer as needed

* #2460 Ensure dollar decimal dollar amounts fail

* #2514 Added placeholder code for workbook version check

* #2514 Switched WB version from formula to value to unblock failing unit tests

* #2514 Code cleaning

* #2567 Increased wb rows

* #2514 Regenerate workbooks

* #2514 Updated workbook version

* Removed unnecessary code since version and section name are now set by value in all workbooks

* More cleaning

* Regenerated test workbooks

* #2514 Enforcing version control

* #2514 Linting

* #2460 Renamed function

* Code restructuring
@github-project-automation github-project-automation bot moved this from In Progress to Done in FAC Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sambodeme sambodeme

Labels
eng
Projects
FAC
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2514 Added placeholder code for workbook version check GSA-TTS/FAC
1 participant
@sambodeme