From 579b2689b5210cfd0e55d9d2c7f15414909fda25 Mon Sep 17 00:00:00 2001 From: Alex Steel <130377221+asteel-gsa@users.noreply.github.com> Date: Wed, 4 Dec 2024 08:26:00 -0500 Subject: [PATCH 1/2] Remove dev zap scan from staging deploy --- .github/workflows/deploy-staging.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/deploy-staging.yml b/.github/workflows/deploy-staging.yml index cdc59bf003..e2acb5d116 100644 --- a/.github/workflows/deploy-staging.yml +++ b/.github/workflows/deploy-staging.yml @@ -14,17 +14,10 @@ jobs: uses: ./.github/workflows/linting.yml secrets: inherit - scan-dev: - name: Zap Scan - uses: ./.github/workflows/zap-scan.yml - with: - url: "https://fac-dev.app.cloud.gov/" - deploy-infrastructure-staging: name: Deploy infrastructure (staging) needs: - testing - - scan-dev uses: ./.github/workflows/terraform-apply-env.yml with: environment: "staging" From 732c3f2590cd6839b3b594c20a8b20d2ca90893f Mon Sep 17 00:00:00 2001 From: Alex Steel <130377221+asteel-gsa@users.noreply.github.com> Date: Wed, 4 Dec 2024 13:50:57 -0500 Subject: [PATCH 2/2] Also happens in prod --- .github/workflows/deploy-production.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/.github/workflows/deploy-production.yml b/.github/workflows/deploy-production.yml index c66205a864..3e1859de3b 100644 --- a/.github/workflows/deploy-production.yml +++ b/.github/workflows/deploy-production.yml @@ -14,18 +14,10 @@ jobs: uses: ./.github/workflows/linting.yml secrets: inherit - # up to date scan of the staging instance - scan-staging: - name: ZAP scan of the staging site - uses: ./.github/workflows/zap-scan.yml - with: - url: "https://fac-staging.app.cloud.gov/" - deploy-infrastructure-production: name: Deploy infrastructure (production) needs: - testing - - scan-staging uses: ./.github/workflows/terraform-apply-env.yml with: environment: "production"