Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test strategy - use Playwright to run storybook tests and perform end-to-end tests in CI #106

Closed
2 tasks done
danielnaab opened this issue Apr 15, 2024 · 0 comments · Fixed by #249
Closed
2 tasks done
Assignees

Comments

@danielnaab
Copy link
Contributor

danielnaab commented Apr 15, 2024

As a project stakeholder, I would like the UI tests to be as useful as possible, while maintaining good DX.

Context: Storybook interaction tests are being used, in a preliminary way, for UI interactions. These tests are orchestrated via a helper that wraps interaction tests with vitest specs, running via JSDOM. This is great, in that we can run the tests fast in watch mode, along-side the rest of the tests in the repository. However, JSDOM is not complete, and some UI tests are not feasible with it. One such example is tests of drag-and-drop behavior in the form manager. Consider: is there a way to continue to get good DX with test suite integration, but utilizing Playwright or another approach?

Acceptance criteria:

  • DnD and other JSDOM-incompatible behavior has automated coverage
  • Testing approach is documented in appropriate ADRs and READMEs
@jimmoffet jimmoffet changed the title Revisit Storybook interaction test runners [Rewrite to include Playwright plans] Revisit Storybook interaction test runners Jul 1, 2024
@jimmoffet jimmoffet changed the title [Rewrite to include Playwright plans] Revisit Storybook interaction test runners [Rewrite to include Playwright plans] Standardize local vs CI test runners, hot reload tests should be fast, CI tests should be comprehensive Jul 1, 2024
@ethangardner ethangardner linked a pull request Jul 5, 2024 that will close this issue
@ethangardner ethangardner changed the title [Rewrite to include Playwright plans] Standardize local vs CI test runners, hot reload tests should be fast, CI tests should be comprehensive Build out testing strategy to include using Playwright to run storybook tests and perform end-to-end tests in CI Jul 9, 2024
@ethangardner ethangardner changed the title Build out testing strategy to include using Playwright to run storybook tests and perform end-to-end tests in CI Enhance test strategy - use Playwright to run storybook tests and perform end-to-end tests in CI Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants