Reusable Terraform Action #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Terraform plan for tts-10x-forms-dev Plan: 0 to add, 1 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
Terraform will perform the following actions:
# cloudfoundry_app.tts-10x-forms-dev-server-doj_tts-10x-forms-dev-server-doj-app_22D74DC4 will be updated in-place
!~ resource "cloudfoundry_app" "tts-10x-forms-dev-server-doj_tts-10x-forms-dev-server-doj-app_22D74DC4" {
!~ docker_image = "ghcr.io/gsa-tts/forms/server-doj:faa676c5ba75d9309045c9a4793ff2b9562c9bc4" -> "ghcr.io/gsa-tts/forms/server-doj:4fca5f98ac801ec230474efba6c2dce8d5e71f72"
id = "29c93a0a-519c-454a-847e-cc603395c2da"
name = "tts-10x-forms-dev-server-doj-app"
# (17 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.📝 Plan generated in Post Terraform plan to PR comment #617 |
danielnaab
approved these changes
Jan 15, 2025
kalasgarov
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had discussed making the terraform install action reusable. However, there seems to be an issue where you can't have multiple uses in github actions where the call chain is file A -> uses file B -> uses file C without involving an artifact. This switches to use the Hashicorp-authored actions/setup-terraform which provides the artifact behavior and to gets around the structuring issue of our current action.