Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make service destination protocol and ports configurable #6

Open
pauldoomgov opened this issue Jun 21, 2024 · 1 comment
Open

Make service destination protocol and ports configurable #6

pauldoomgov opened this issue Jun 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@pauldoomgov
Copy link
Contributor

pauldoomgov commented Jun 21, 2024 •
edited by callaghangsa
Loading

The current implementation in prepare.sh is hard coded with tcp and ports 20 through 10000. Pulling this up to be configurable in manifest.yml would be a nice first step. I am unsure if allowing configuration in .gitlab-ci.yml at run time is worth the lift and considering the ability to modify it with the code, is probably less secure.

Considerations:

  • Deploy-time option
  • Configurable in Gitlab CI yaml
@pauldoomgov pauldoomgov mentioned this issue Jun 21, 2024
Merged
@pauldoomgov pauldoomgov added the enhancement New feature or request label Jun 21, 2024
@callaghangsa
Copy link

We will look at this when we've finished the GO re-write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pauldoomgov @callaghangsa