Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit loading credentials from ENV once runner cmd's are more clear. #67

Open
zjrgov opened this issue Dec 13, 2024 · 1 comment
Open
Assignees

Comments

@zjrgov
Copy link
Contributor

zjrgov commented Dec 13, 2024

This issue is just a reminder to revisit the way credentials are loaded in cf-executor/cg/creds.go. They currently load straight from the OS environment but we might want to move that once it's more clear how everything will be instantiated.

@zjrgov zjrgov self-assigned this Dec 13, 2024
zjrgov added a commit that referenced this issue Dec 13, 2024
@rahearn
Copy link
Contributor

rahearn commented Dec 16, 2024

This is likely to be the best/most straight forward way to do it moving forward as well, but I'm good with leaving this open and revisiting once the architecture is more settled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants