Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to keep GLR-W/S from being cleaned #40

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add flags to keep GLR-W/S from being cleaned #40

merged 1 commit into from
Sep 19, 2024

Conversation

zjrgov
Copy link
Contributor

@zjrgov zjrgov commented Sep 19, 2024 •
edited
Loading

🎫 Addresses issue: #39

Flags to skip worker/service cleanup.

🛠 Summary of changes

When triggering a manual pipeline you can add these variables to cleanup of workers and/or services. The variables are PRESERVE_WORKER, and PRESERVE_SERVICES respectively. The CUSTOM_ENV_… gets appended by the runner.

@zjrgov zjrgov requested a review from a team September 19, 2024 15:57
@zjrgov zjrgov self-assigned this Sep 19, 2024
rahearn
rahearn reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] if one were to use this, how do the services eventually get cleaned up? Or is this intended to be used only by us in the short term so a fully manual cleanup is ok?

@zjrgov
Copy link
Contributor Author

zjrgov commented Sep 19, 2024

@rahearn yeah that's the idea--manual cleanup. The cleanup is relatively easy and much quicker.

The alternative right now is manually disabling cleanup in the script and redeploying the runner which is slow and global so potentially disruptive.

rahearn
rahearn approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though I think we should create a follow on ticket to implement an automatic eventual cleanup, similar to how circleci will cleanup instances 10 minutes after the ssh connection terminates.

@zjrgov
Copy link
Contributor Author

zjrgov commented Sep 19, 2024

@rahearn feel OK with me expanding #34?

@rahearn
Copy link
Contributor

rahearn commented Sep 19, 2024

@rahearn feel OK with me expanding #34?

Yes!

@zjrgov zjrgov mentioned this pull request Sep 19, 2024
Open
@zjrgov zjrgov merged commit a07b86c into main Sep 19, 2024
@zjrgov zjrgov deleted the zjr/glr-preserver branch September 19, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahearn rahearn rahearn approved these changes

Assignees

@zjrgov zjrgov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjrgov @rahearn