Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node version in Build / Test workflow #103

Closed
wesley-dean-gsa opened this issue Jul 18, 2024 · 4 comments · Fixed by #140
Closed

Update Node version in Build / Test workflow #103

wesley-dean-gsa opened this issue Jul 18, 2024 · 4 comments · Fixed by #140
Assignees

Comments

@wesley-dean-gsa
Copy link
Contributor

wesley-dean-gsa commented Jul 18, 2024

The current Pa11y and proposed Test workflows hard-code Node version 17. Version 17 is no longer supported by either the Node or the Pages communities.

@wesley-dean-gsa
Copy link
Contributor Author

While on BEARS, I used nvm (Node Version Manager) to manage the version of Node that's used:

https://github.com/GSA-TTS/usagov-benefits-eligibility/blob/main/.github/workflows/test.yml#L20-L27

Adopting this (or something like it) will allow us to use nvm for Node version management; in the above case, the .nvmrc only includes 18 so nvm will use the most recent version of Node version 18.

Currently, Pages uses nvm and supports the "active and maintenance LTS" releases of Node with the default version being 18 (specifically, 18.19.0).

@wesley-dean-gsa
Copy link
Contributor Author

The Node release / support documentation is here: https://github.com/nodejs/release#release-schedule

@wesley-dean-gsa
Copy link
Contributor Author

In #105, the Pa11y workflow was updated to use the live preview URLs generated by Cloud.gov Pages. As a result, we're no longer building the site, so we don't need to install requirements from package.json. All of that said, we're no longer tied to the version of Node required by the site, just the tool. Pa11y currently supports versions 18 and 20. As the current default for Cloud.gov Pages is Node 18.19.0, we just told it to use version 18 and let the system figure it out.

tl;dr: the Pa11y workflow no longer needs to be updated.

@wesley-dean-gsa wesley-dean-gsa added this to the Technical Debt milestone Jul 23, 2024
@wesley-dean-gsa wesley-dean-gsa changed the title Update Node version in Pa11y and Test workflows Update Node version in Build / Test workflow Aug 2, 2024
@wesley-dean-gsa wesley-dean-gsa moved this from Todo to In Progress in TTS Website Aug 2, 2024
@wesley-dean-gsa wesley-dean-gsa linked a pull request Aug 2, 2024 that will close this issue
@wesley-dean-gsa wesley-dean-gsa moved this from In Progress to Needs Review in TTS Website Aug 2, 2024
@wesley-dean-gsa
Copy link
Contributor Author

FWIW, we went from 16.15.1 => 18.19.0. This update required a change in the .eleventy.js configuration to make work locally; however, as a part of #136, we integrated that change which, apparently, is backwards-compatible.

@github-project-automation github-project-automation bot moved this from Needs Review to Done in TTS Website Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant