Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS #131

Closed
wesley-dean-gsa opened this issue Jul 30, 2024 · 3 comments · Fixed by #138
Closed

Add CODEOWNERS #131

wesley-dean-gsa opened this issue Jul 30, 2024 · 3 comments · Fixed by #138
Assignees
@wesley-dean-gsa
Labels
Task This issue represents a Task
Milestone
Technical Debt

Comments

@wesley-dean-gsa
Copy link
Contributor

Add a CODEOWNERS file to direct PR review requests to the appropriate people.
@wesley-dean-gsa wesley-dean-gsa added the Task This issue represents a Task label Jul 30, 2024
@wesley-dean-gsa wesley-dean-gsa added this to the Technical Debt milestone Jul 30, 2024
@wesley-dean-gsa wesley-dean-gsa self-assigned this Jul 30, 2024
@wesley-dean-gsa wesley-dean-gsa moved this from Todo to In Progress in TTS Website Jul 31, 2024
@wesley-dean-gsa
Copy link
Contributor Author

I put in a request via #github-admins in Slack for the group membership update given our conversation on Tuesday, July 30th. Once that's done, we can update the CODEOWNERS file.

@wesley-dean-gsa
Copy link
Contributor Author

Here's what I'm thinking:

  • default / fallback is to request reviews of the GSA-TTS/tts-website team
  • GSA-TTS/tts-website/content for *.html, *.md (i.e., files that have veribage-type content)
  • GSA-TTS/tts-website/design for *.html, *.js, *.ts, *.css (i.e., files that relate to design and presentation)
  • GSA-TTS/tts-website/development for *.html, *.js, *.ts, .yaml, .json, *.php` (i.e., files that relate to development stuff (this is a bit redundant at the moment but may change in the future))
  • GSA-TTS/tts-website/talent for pages/jointts/** (i.e., stuff relating to job postings)
  • GSA-TTS/tts-website/admin for .github/** (i.e., workflows and such)

@wesley-dean-gsa
Copy link
Contributor Author

We're currently blocked while waiting for the GitHub admins to update group membership.

@wesley-dean-gsa wesley-dean-gsa mentioned this issue Aug 2, 2024
Merged
@wesley-dean-gsa wesley-dean-gsa linked a pull request Aug 2, 2024 that will close this issue
Create CODEOWNERS #138
Merged
@wesley-dean-gsa wesley-dean-gsa moved this from In Progress to Needs Review in TTS Website Aug 2, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in TTS Website Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesley-dean-gsa wesley-dean-gsa

Labels
Task This issue represents a Task
Projects
TTS Website
Archived in project
Milestone
Technical Debt
Development

Successfully merging a pull request may close this issue.

Create CODEOWNERS GSA-TTS/tts.gsa.gov
1 participant
@wesley-dean-gsa