Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MegaLinter to apply fixes and only scan changed files #139

Closed
wesley-dean-gsa opened this issue Aug 2, 2024 · 2 comments · Fixed by #144
Closed

Update MegaLinter to apply fixes and only scan changed files #139

wesley-dean-gsa opened this issue Aug 2, 2024 · 2 comments · Fixed by #144
Assignees
@wesley-dean-gsa
Milestone
Technical Debt

Comments

@wesley-dean-gsa
Copy link
Contributor

Given #134 (tidy MegaLinter findings), we're now save to enable APPLY_FIXES and restrict scanning to only changed files.
@wesley-dean-gsa wesley-dean-gsa added this to the Technical Debt milestone Aug 2, 2024
@wesley-dean-gsa wesley-dean-gsa self-assigned this Aug 5, 2024
@wesley-dean-gsa wesley-dean-gsa moved this from Todo to In Progress in TTS Website Aug 5, 2024
@wesley-dean-gsa
Copy link
Contributor Author

I ran a test locally and saw that pretty much everything that can be automatically fixes has been. However, one of the files (styles/tts-custom-styles.scss) horked a comment which caused builds to break. We may need to manually refactor this into multiple lines to prevent that from happening before turning on APPLY_FIXES.

@wesley-dean-gsa wesley-dean-gsa linked a pull request Aug 5, 2024 that will close this issue
Have MegaLinter only scan changed files #142
Closed
@wesley-dean-gsa
Copy link
Contributor Author

A PAT was generated and added to the repo as an actions secret. This is the credential GitHub will use to push updates back to the repository when APPLY_FIXES is set to all or a list of linter keys.

Image

@wesley-dean-gsa wesley-dean-gsa mentioned this issue Aug 6, 2024
Merged
@wesley-dean-gsa wesley-dean-gsa moved this from In Progress to Needs Review in TTS Website Aug 6, 2024
@wesley-dean-gsa wesley-dean-gsa removed a link to a pull request Aug 6, 2024
Have MegaLinter only scan changed files #142
Closed
@wesley-dean-gsa wesley-dean-gsa linked a pull request Aug 6, 2024 that will close this issue
Have MegaLinter apply fixes and only scan updated files #144
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesley-dean-gsa wesley-dean-gsa

Labels
None yet
Projects
TTS Website
Status: Done
Milestone
Technical Debt
Development

Successfully merging a pull request may close this issue.

Have MegaLinter apply fixes and only scan updated files GSA-TTS/tts.gsa.gov
1 participant
@wesley-dean-gsa