Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site-wide Favicon #79

Closed
wesley-dean-gsa opened this issue Jul 17, 2024 · 4 comments · Fixed by #128
Closed

Update site-wide Favicon #79

wesley-dean-gsa opened this issue Jul 17, 2024 · 4 comments · Fixed by #128

Comments

@wesley-dean-gsa
Copy link
Contributor

Favicon should be the same as JoinTTS

@wesley-dean-gsa
Copy link
Contributor Author

wesley-dean-gsa commented Jul 29, 2024

@wesley-dean-gsa
Copy link
Contributor Author

The current site has no reference to any favicons in any of the HTML, nor are there any icon files that I can find in the site source.

@wesley-dean-gsa
Copy link
Contributor Author

wesley-dean-gsa commented Jul 29, 2024

Join's favicon is here: https://join.tts.gsa.gov/favicon.ico
It's 128x128x32b; best case would be to support 32x32, 180x180, 192x192, and 512x512.

@wesley-dean-gsa
Copy link
Contributor Author

Chatted with @katelandisgsa (Slack) and we're going to stick with the current favicon.

We'll need to add the icon file to the _img folder, update the eleventy.js file for the image pass-through, and update meta.html to include the image.

for meta.html:

<link rel="icon" href="/favicon.ico" sizes="any">

for eleventy.js:

// Copy `img/favicon/` to `_site/`
eleventyConfig.addPassthroughCopy({ "_img/favicon": "/" });

@debjudy debjudy moved this from Todo to Done in TTS Website Jul 30, 2024
@debjudy debjudy closed this as completed by moving to Done in TTS Website Jul 30, 2024
@wesley-dean-gsa wesley-dean-gsa linked a pull request Jul 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants