Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ckanext-report in catalog-app #1417

Closed
12 tasks
avdata99 opened this issue Feb 27, 2020 · 1 comment
Closed
12 tasks

Upgrade ckanext-report in catalog-app #1417

avdata99 opened this issue Feb 27, 2020 · 1 comment

Comments

@avdata99
Copy link
Contributor

avdata99 commented Feb 27, 2020

Description

In the catalog-app we are using a fork of the ckanext-qa extension (on the datagov branch). We are not sure about which repo should be consider upstream.

As a part of a plan to upgrade CKAN extensions in use, and in order to improve the way that we manage forks we need to upgrade this extension.

Acceptance Criteria

  • When there's a new release upstream, we can get onto it in under an hour
  • When there's a new release upstream, we see a notification in a Slack channel
  • If the upstream maintainers don't already use versioning, there's an issue in their tracker requesting they do.
  • If the upstream maintainers don't already have tests, there's an issue in their tracker requesting they add them.
  • We have tests for this extension running in CI (upstream have no tests or CI)

Tasks

  • Create a test environment with the catalog-app
  • Ask upstream for tests and CI
  • Test (by now) manually this extension in this environment.
  • Measure the effort to move the catalog-app to this upstream version.
  • Upstream do not use tags for versions, do not have a change log file and version is 0.1 from the begining (6 years ago). Ask upstream for improve versioning.
  • If we consider this extension as an important one, do a deep analysis on forks to check for bug fixes or improvements.
  • Connect our Slack channel with new release news in upstream

Analysis & notes

DavidRead version starts this repo (we consider this repo upstream by now). Last update: Mar 22, 2017
GSA version last update: March 9, 2016

Other repos continue working on it until today. They just work to upgrade to py3 and add translation capabilities
forks

Our fork is Ahead in 36 commits and Behind 49 commits but these versions have not diverged a lot. This potential PR show us the changes between our datagov branch and upstream. The changes do not seem significant. It should not require much effort updating to this version.

It's a good idea to define an environment with the catalog-app and just change ckanext-report to the official version and run tests.

Recommendation

Define the upstream version and move to it

@nickumia-reisys
Copy link
Contributor

https://github.com/ckan/ckanext-report/ is the upstream version and we have it integrated on current catalog,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants