-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block non-ckan routes from inventory-proxy #4044
Comments
Since you asked yesterday @robert-bryson, it's not necessary to whitelist each full route independently. We can still gain a lot of benefit by just whitelisting the top-level routes (i.e. the "Parent" Routes minus the '/' route). We'll want Edit 1: The only routes that may be problematic are the "static files" (i.e. the webassets [js/css] and any other files that have custom routes. I don't anticipate this to be a large effort, but if anyone knows differently, please advise. Edit 2: If you are still worried about having to maintain a bunch of code in the |
With this PR and a successful deploy into prod, this is done. I think this will be something of a first pass on reducing noise in New Relic. Future work to tighten the rules further may be needed. As written this ticket targets inventory specifically. @nickumia-reisys & @FuhuXia & team as a whole, do you think this will need to be done for catalog as well? |
User Story
In order to reduce noisy logs, the Data.gov security team wants to prevent non-ckan traffic from hitting the ckan app and causing non-helpful errors.
Acceptance Criteria
[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]
WHEN a non-ckan route is accessed from such as https://inventory.data.gov/vulnerable.php
THEN There should not be errors in NR
Background
[Any helpful contextual notes or links to artifacts/evidence, if needed]
Security Considerations (required)
[Any security concerns that might be implicated in the change. "None" is OK, just be explicit here!]
Sketch
[Notes or a checklist reflecting our understanding of the selected approach]
The text was updated successfully, but these errors were encountered: