From 94ec77ebad6f2fb787df1ed189d311e3a6538a2d Mon Sep 17 00:00:00 2001 From: christian medders Date: Wed, 30 Oct 2024 14:09:37 -0400 Subject: [PATCH 1/3] DIGITAL-109: Proposed PR tempalte --- .github/pull_request_template.md | 62 ++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..1a56da26 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,62 @@ + + +## Jira ticket + + + +[DIGITAL- ]() + +## Purpose + + + +## Deployment and testing + +### Local Setup + + + +### QA/Testing instructions + + + +## Checklist for the Developer + + + +- [ ] A link to the JIRA ticket has been included above. +- [ ] No merge conflicts exist with the target branch. +- [ ] Automated tests have passed on this PR. +- [ ] A reviewer has been designated. +- [ ] Deployment and testing steps have been documented above, if applicable. + +## Checklist for the Peer Reviewers + +- [ ] The file changes are relevant to the task objective. +- [ ] Code is readable and includes appropriate commenting. +- [ ] Code standards and best practices are followed. +- [ ] QA/Test steps were successfully completed, if applicable. +- [ ] Applicable logs are free of errors. + + From def76961cd31014cded21f4ddfa7f37c68344afe Mon Sep 17 00:00:00 2001 From: christian medders Date: Wed, 30 Oct 2024 14:17:13 -0400 Subject: [PATCH 2/3] DIGITAL-109: File clean up --- .github/pull_request_template.md | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 1a56da26..81e6f0a4 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -3,37 +3,29 @@ ## Jira ticket - + + [DIGITAL- ]() ## Purpose - +4. Possible limitations of this approach and alternate solution paths. --> ## Deployment and testing ### Local Setup - + ### QA/Testing instructions - + ## Checklist for the Developer From 983a8cee82e9a52c4964e3b6f484bdcf458d50ea Mon Sep 17 00:00:00 2001 From: christian medders Date: Wed, 30 Oct 2024 21:41:12 -0400 Subject: [PATCH 3/3] DIGITAL-109: Tempalte updates --- .github/pull_request_template.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 81e6f0a4..d547d07d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -3,9 +3,9 @@ ## Jira ticket - + -[DIGITAL- ]() +[DIGITAL-]() ## Purpose @@ -17,6 +17,10 @@ It can be helpful to understand: 3. How you implemented the change 4. Possible limitations of this approach and alternate solution paths. --> +## Includes the following PRs that must be merged first + + + ## Deployment and testing ### Local Setup @@ -49,6 +53,6 @@ It can be helpful to understand: Before opening this PR, make sure you’ve done whichever of these applies to you: - Branch is up-to-date and includes latest from `develop` - Target branch is correct -- You have ran code standards locally before assigning `./robo.sh validate:all` +- You have ran code standards locally before assigning -`./robo.sh validate:all` - PR is clear in both the reason it was opened and how the reviewer can confirm the work is done -->