Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template stats is providing limited data, we don't have enough information to populate all the content needed for the new template table. #1265

Open
heyitsmebev opened this issue Aug 13, 2024 · 2 comments · Fixed by #1304
Assignees

Comments

@heyitsmebev
Copy link
Contributor

heyitsmebev commented Aug 13, 2024

It seems that the endpoint for the template stats is providing limited data, and we don't have enough information to populate all the content needed for the table.

This template stats endpoint : url="/service/{}/template-statistics".format(service_id)

Data missing:

  1. Folder
  2. Last used
  3. Created by
  4. Number times used

Image

Originally posted by @heyitsmebev in GSA/notifications-admin#1487 (comment)

@heyitsmebev heyitsmebev transferred this issue from GSA/notifications-admin Aug 13, 2024
@heyitsmebev heyitsmebev moved this from 🌱 New to ⬇ Up-Next in Notify.gov product board Aug 13, 2024
@heyitsmebev heyitsmebev changed the title Template stats is providing limited data, and we don't have enough information to populate all the content needed for the table. Template stats is providing limited data, we don't have enough information to populate all the content needed for the new template table. Aug 13, 2024
@xlorepdarkhelm xlorepdarkhelm self-assigned this Aug 16, 2024
@xlorepdarkhelm xlorepdarkhelm moved this from ⬇ Up-Next to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Aug 16, 2024
@xlorepdarkhelm
Copy link
Contributor

From what I can tell, count is the # of times used. It is an aggregate sum of all of the notification status entries matching the row being made, which I believe represents the number of notifications that used that template.

@xlorepdarkhelm
Copy link
Contributor

xlorepdarkhelm commented Aug 16, 2024

Note to self:

"created by" is on the Template
"folder" is on the TemplateFolder
"last used" would be the "local_date" on the FactNotificationStatus or today's date if there is a Notification entry for today.

@heyitsmebev heyitsmebev linked a pull request Aug 29, 2024 that will close this issue
@heyitsmebev heyitsmebev moved this from 🏗 In progress (WIP: ≤ 3 per person) to ✅ Done in Notify.gov product board Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants