refactor(systemvolume): remove requestSinks

Sinks are sent at connect time and updated as necessary, so drop the request command. See: https://invent.kde.org/network/kdeconnect-meta/-/merge_requests/8
GSConnect · Nov 14, 2024 · d60fdba · d60fdba
1 parent 734ef1e
commit d60fdba
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 21 deletions.
diff --git a/installed-tests/suites/plugins/testSystemvolumePlugin.js b/installed-tests/suites/plugins/testSystemvolumePlugin.js
@@ -78,23 +78,6 @@ describe('The systemvolume plugin', function () {
         expect(localPlugin._sendSinkList).toHaveBeenCalled();
     });
 
-    it('sends a list of streams when requested', async function () {
-        spyOn(remoteDevice, 'handlePacket').and.callThrough();
-
-        remoteDevice.sendPacket({
-            type: 'kdeconnect.systemvolume.request',
-            body: {
-                requestSinks: true,
-            },
-        });
-
-        await localPlugin.awaitPacket('kdeconnect.systemvolume.request', {
-            requestSinks: true,
-        });
-
-        await remoteDevice.awaitPacket('kdeconnect.systemvolume');
-    });
-
     it('handles volume level requests', async function () {
         remoteDevice.sendPacket({
             type: 'kdeconnect.systemvolume.request',

diff --git a/src/service/plugins/systemvolume.js b/src/service/plugins/systemvolume.js
@@ -63,10 +63,6 @@ const SystemVolumePlugin = GObject.registerClass({
 
     handlePacket(packet) {
         switch (true) {
-            case packet.body.hasOwnProperty('requestSinks'):
-                this._sendSinkList();
-                break;
-
             case packet.body.hasOwnProperty('name'):
                 this._changeSink(packet);
                 break;