Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize appstream screenshot, or provide alternative #1815

Closed
wants to merge 3 commits into from

Conversation

ferdnyc
Copy link
Member

@ferdnyc ferdnyc commented May 27, 2024

According to appstream-util, the maximum permitted size for the app screenshot is 1600x900.

Draft because there are two options here, and I'm looking for input on which one to go with.

I attempted to resize the screenshot without scaling it (to avoid losing detail), by pulling the elements in closer to each other. But everything ended up overlapping and I wasn't very happy with the result. That version is in gsconnect-overlapping.png (with the .xcf source file also included).

Since I wasn't satisfied with that version, I also scaled the existing image to 1600x900, and saved it back in place of the previous file.

So, take a look and see what you think. If you like the -overlapping version, I can make that the new screenshot. If not, I can drop that commit and push the rescaled image-01.png.

Copy link
Collaborator

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either seems okay with me. It's not terribly up to date, but it's really only a visual overview of features anyways.

@ferdnyc
Copy link
Member Author

ferdnyc commented May 27, 2024

I may be wrong about the max screenshot size, anyway. That info comes from appstream-util validate-strict, which I'm beginning to get the impression is out of date compared to appstreamcli. And that doesn't complain about the 1920×1080 screenshot even in its most strict mode.

The current spec includes no minimum or maximum size restrictions at all (I get the impression that guidance has been evolving), although all of the examples do still show screenshot tags for 1600px x 900px images.

@ferdnyc
Copy link
Member Author

ferdnyc commented May 28, 2024

I'm going to close this, as I no longer think the information about 1600x900 being the max screenshot size is correct w/r/t the actual AppStream spec. And since the version of the smaller screenshot that I preferred was the scaled-down one, it makes no difference if we leave it to AppStream consumers to handle resizing the image.

(Plus, if they'll be showing it smaller than 1600x900 — which seems likely — then it'll look better scaled down from 1920x1080 than if it's double-scaled first to 1600x900, then to whatever size it's displayed at.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants