Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Red bench does not check validity of the craft, possible abuse #16829

Open
3 tasks done
qDshun opened this issue Jul 23, 2024 · 0 comments
Open
3 tasks done

Project Red bench does not check validity of the craft, possible abuse #16829

qDshun opened this issue Jul 23, 2024 · 0 comments

Comments

@qDshun
Copy link

qDshun commented Jul 23, 2024

Your GTNH Discord Username

qDshun#3433

Your Pack Version

2.6.1

Your Server

Singleplayer GoG, also played in Zvezdolet for a bit

Java Version

Java 8

Type of Server

Single Player

Your Expectation

Project Red crafting bench considers if stuff could be made with this input

The Reality

Project Red crafting bench does not care about being actually able to craft items from the input, it only cares that items in the inventory match AT LEAST ONE of the tags (oredictionary?) of the items in the recipe.
So what is possible with it:

  • make annealed copper from normal one
  • duplicate water/milk (ProjectRed Expansion Auto Crafting Bench duplicates Fresh Milk #14537)
  • replace any item from the recipe with other item that has atleast one tag (especially funny shenanigans could happen when item has tag "any", like "ingotAny" or "rubberAny"
  • freely exchange between different plastics
  • and many many more with creative use of it

Your Proposal

I haven't digged into the source so idk why this bug happens, but make it behave like other autocrafting benches

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@qDshun qDshun added Status: Triage Issue awaiting triage. Remove once this issue is processed Bug: Minor labels Jul 23, 2024
@chochem chochem added Type: Exploit Mod: Project Red and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants