Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Item Holders even better #17770

Open
4 tasks done
lailani-f opened this issue Oct 26, 2024 · 4 comments
Open
4 tasks done

Make Item Holders even better #17770

lailani-f opened this issue Oct 26, 2024 · 4 comments
Assignees
Labels
Status: Ready for Developer Issue ready for a developer to pick up and implement Suggestion Type: QoL

Comments

@lailani-f
Copy link

lailani-f commented Oct 26, 2024

Your GTNH Discord Username

cure.starlight

Your Pack Version

2.7.0-beta3

Your Proposal

The new Item Holders are great and let you store lenses/extruder shapes etc. right inside the machine. However accessing stored items is a bit cumbersome as the holder needs to be opened by clicking on its cover icon inside the machine GUI every time the machine is accessed. Furthermore the holder GUI opens far off to the side of the machine GUI which does not seem ideal. It can be manually moved around but will not remember its position once the machine GUI is closed and reopened. Lastly once the holder GUI is open it will intercept the ESC or E key used to usually close the whole machine GUI, making it necessary to hit the key twice to reach the desired result.

I therefore propose the Item Holder GUI to remember its position and opened state and to ignore ESC and E keypress.

[Item Holder GUI opens far to the side.]
image

Your Goal

Make the Item Holder even better by making its use more intuitive and seemless.

Your Vision

A smoll QoL change surely noone can resist!

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying I like this change please reconsider adding it will prompt us to investigate and reopen it once we confirm your report.
  • I understand this change request may not attract enough attention and thus not be implemented.
  • I understand this change request may be rejected due to other community members think it's inappropriate.
  • I believe this feature would make the pack better.
@lailani-f lailani-f added Status: Triage Issue awaiting triage. Remove once this issue is processed Suggestion labels Oct 26, 2024
@Rika-TH
Copy link
Contributor

Rika-TH commented Oct 26, 2024

This would be amazing, after we finally found the name of it (might be a bit better as hear there's a quest now) us and our teammate both had this exact type of annoyance, the positioning is so dum

@Ruling-0 Ruling-0 added Type: QoL Status: Ready for Developer Issue ready for a developer to pick up and implement and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 8, 2024
@Impos913
Copy link
Contributor

I agree with this suggestion, using the holder is pointless imo if I have to reopen its gui every time i open the machine

@Miklebe Miklebe mentioned this issue Nov 29, 2024
4 tasks
@Glease
Copy link
Contributor

Glease commented Dec 8, 2024

I agree that this is indeed a problem. here are some thoughts on the implementation

  1. make item holder autoopen on gui open.
  2. tile the holders to the left of the screen, as close to the main gui as possible
  3. remember the location of holder gui on client side

all of these have the same issue: what if there are multiple holder cover here?

@DownerCase
Copy link

I agree that this is indeed a problem. here are some thoughts on the implementation

  1. make item holder autoopen on gui open.
  2. tile the holders to the left of the screen, as close to the main gui as possible
  3. remember the location of holder gui on client side

all of these have the same issue: what if there are multiple holder cover here?

  • Default state of the holder should be closed and it will remember its state (position and open/close).
  • Default opening position doesn't matter too much.
  • Opening a holder will have it render above any already open holders (to prevent it being totally hidden)
  • Add an icon that suggests the window can be moved (I had no idea until seeing someone mention it! (Not that it really matters with it currently not saving that position...))

This way the user will know they can move the holders however they want, and won't be confused by a holder opening behind another.

@Glease Glease self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready for Developer Issue ready for a developer to pick up and implement Suggestion Type: QoL
Projects
None yet
Development

No branches or pull requests

6 participants