Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findIt crash when searching nearby containers for thaumcraft knowledge fragments ("stackAspects" is null) #18017

Closed
2 of 3 tasks
Flakxo opened this issue Nov 18, 2024 · 3 comments · Fixed by GTNewHorizons/FindIt#26

Comments

@Flakxo
Copy link

Flakxo commented Nov 18, 2024

Your GTNH Discord Username

.flaxo

Your Pack Version

2.7.0-nightly-2024-11-11

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Actions

Using findIt to try and locate knowledge fragments from thaumcraft in nearby containers causes a crash to menu screen

Crash Report

https://mclo.gs/NqsBdB9

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the crash still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this crash consistently by following the exact steps I described above.
  • I have asked other people and they confirm they also crash by following the exact steps I described above.
@Flakxo Flakxo added Crash Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 18, 2024
Copy link
Contributor

Found 1 linked crash report(s)

Primitive Automated Analysis of Crash Report

https://mclo.gs/NqsBdB9

Stacktrace
java.lang.NullPointerException: Cannot invoke "thaumcraft.api.aspects.AspectList.size()" because "stackAspects" is null
  at com.gtnh.findit.handler.ThaumcraftProvider$AspectStackFilter.matches(ThaumcraftProvider.java:35)
  at com.gtnh.findit.service.itemfinder.FindItemRequest.isStackSatisfies(FindItemRequest.java:75)
  at com.gtnh.findit.service.itemfinder.ClientItemFindService$TickListener.onClientPostTick(ClientItemFindService.java:132)
  at cpw.mods.fml.common.eventhandler.ASMEventHandler_804_TickListener_onClientPostTick_ClientTickEvent.invoke(.dynamic)
  at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
  at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
  at cpw.mods.fml.common.FMLCommonHandler.onPostClientTick(FMLCommonHandler.java:330)
  at net.minecraft.client.Minecraft.runTick(Minecraft.java:2064)
  at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:973)
  at net.minecraft.client.Minecraft.run(Minecraft.java:6110)
  at net.minecraft.client.main.Main.main(SourceFile:148)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source)
  at java.lang.reflect.Method.invoke(Unknown Source)
  at net.minecraft.launchwrapper.Launch.rfb$realLaunch(Launch.java:250)
  at net.minecraft.launchwrapper.Launch.launch(Launch.java:35)
  at net.minecraft.launchwrapper.Launch.main(Launch.java:60)
  at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source)
  at java.lang.reflect.Method.invoke(Unknown Source)
  at com.gtnewhorizons.retrofuturabootstrap.Main.main(Main.java:207)
  at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
  at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
  at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

@Alexdoru
Copy link
Member

this is fixed already you can download the updated version of the mod here https://github.com/GTNewHorizons/FindIt/releases

@Alexdoru Alexdoru closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2024
@wlhlm
Copy link
Member

wlhlm commented Nov 19, 2024

The crashlog above shows a different NPE. This will hopefully be fixed by GTNewHorizons/FindIt#26

@wlhlm wlhlm reopened this Nov 19, 2024
@wlhlm wlhlm added Mod: FindIt and removed Status: Triage Issue awaiting triage. Remove once this issue is processed labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants