Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect "LootGames" config gets created #18502

Closed
3 tasks done
jurrejelle opened this issue Dec 25, 2024 · 4 comments · Fixed by #18717
Closed
3 tasks done

incorrect "LootGames" config gets created #18502

jurrejelle opened this issue Dec 25, 2024 · 4 comments · Fixed by #18717
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed

Comments

@jurrejelle
Copy link

jurrejelle commented Dec 25, 2024

Your GTNH Discord Username

jurrejelle

Your Pack Version

2.7.1

Your Server

Private Server

Java Version

Java 21

Type of Server

Multiplayer

Your Expectation

When you create a server, a file gets created called config/LootGames/rewards.cfg

The Reality

this doesn't get used, and then when launching, a default file called config/lootgames/rewards.cfg gets used instead

Your Proposal

Fix the config file

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@jurrejelle jurrejelle added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed labels Dec 25, 2024
@jurrejelle
Copy link
Author

Reproduction steps in linux server:
wget https://downloads.gtnewhorizons.com/ServerPacks/GT_New_Horizons_2.7.1_Server_Java_17-21.zip

unzip GT_New_Horizons_2.7.1_Server_Java_17-21.zip

cat config/LootGames/rewards.cfg

echo "eula=true" > eula.txt
chmod +x startServer-java9.sh
./startServer-java9.sh

cat config/lootgames/rewards.cfg

@paulzzh
Copy link
Contributor

paulzzh commented Jan 8, 2025

Please fix this.
LootGames are using default loot-table. (1:dungeonChest, 2:mineshaftCorridor, 3:loot-tables, 4:strongholdCorridor)
Should be (1:chest1, 2:chest2, 3:chest3, 4:chest4)
People who reach Stage 4 receive useless garbage.
Additionally, there may be an issue of galacticgreg vs. GalacticGreg
image

@Demosthenexx
Copy link

I just had to manually patch our server. Can this be added to the list of fixes for 2.7.3?

@serenibyss
Copy link
Member

@Demosthenexx Sure, I added it just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants