Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KedroMlflowConfig should not create experiment when instantiated #97

Closed
Galileo-Galilei opened this issue Oct 18, 2020 · 0 comments · Fixed by #126
Closed

KedroMlflowConfig should not create experiment when instantiated #97

Galileo-Galilei opened this issue Oct 18, 2020 · 0 comments · Fixed by #126
Labels
enhancement New feature or request
Milestone

Comments

@Galileo-Galilei
Copy link
Owner

Description

The KedroMlflowConfig class is intended to manage kedro-mlflow configuration. However, it does not only read the configuration file, but also interacts with the mlflow database. For instance, it creates an experiment at instantiation with the _get_or_create_experiment function

def _get_or_create_experiment(self) -> mlflow.entities.Experiment:

Context

We should striclty separate storing the conf and setting it up to avoid side effects.

Possible Implementation

Create a setup() method which:

  • create the mlflow client
  • get or create the mlflow experiment
  • set the tracking uri

This wil enable to call config.setup() where needed in the code. This is also intended to make credentials management easier.

@Galileo-Galilei Galileo-Galilei added the enhancement New feature or request label Oct 18, 2020
@Galileo-Galilei Galileo-Galilei added this to the Release 0.5.0 milestone Oct 18, 2020
@Galileo-Galilei Galileo-Galilei changed the title KedroMlflowConfig should no create experiment when instantiated KedroMlflowConfig should not create experiment when instantiated Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
1 participant