Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --save-smt/--save-macaw options accept a directory to create files in #413

Open
RyanGlScott opened this issue Jul 26, 2024 · 1 comment
Labels
enhancement symbolic-execution Issues relating to macaw-symbolic and symbolic execution testing Issues related to the test suite

Comments

@RyanGlScott
Copy link
Contributor

The test suites for the macaw-*-symbolic suite of packages define --save-smt/--save-macaw switches, which can be used to dump intermediate SMT queries and Macaw CFGs to text files under the /tmp directory for debugging purposes. In #411 (comment), @kquick observed that this isn't quite ideal, since generating these files in a global location like /tmp can mix them in with other runs of the test suite, possibly leading to users looking at the wrong files.

Instead, it would be better if --save-smt/--save-macaw each took a directory as an argument, dumping their contents to files contained in that directory. That way, the user can generate the files to a known location (e.g., the current directory). This would also make it easier to generate these files during CI and possibly save them as artifacts.

@RyanGlScott RyanGlScott added enhancement symbolic-execution Issues relating to macaw-symbolic and symbolic execution testing Issues related to the test suite labels Jul 26, 2024
@sauclovian-g
Copy link
Contributor

Also, on a multiuser/server machine dropping stuff with predictable names in /tmp (without taking precautions) is a bad idea and can lead to security advisories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement symbolic-execution Issues relating to macaw-symbolic and symbolic execution testing Issues related to the test suite
Projects
None yet
Development

No branches or pull requests

2 participants