Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing CODECLIMATE_REPO_TOKEN for Github Actions #619

Closed
mikabytes opened this issue Feb 22, 2024 · 0 comments · Fixed by #620
Closed

Missing CODECLIMATE_REPO_TOKEN for Github Actions #619

mikabytes opened this issue Feb 22, 2024 · 0 comments · Fixed by #620
Assignees
@trotzig

Comments

@mikabytes
Copy link
Collaborator

Just noticed in #618 that the tests are failing. It's mentioning something about this env variable. @trotzig do you have a few minutes to check it out? Thanks.
trotzig added a commit that referenced this issue Feb 22, 2024
@trotzig
Disable codeclimate when env var is missing
82dca9c 
When outside contributors, e.g. dependabot, pushes a PR, the
CODECLIMATE_REPO_TOKEN env variable is not present (it's a secret
defined on the github account). We can ignore the codeclimate report in
these cases to let tests still pass.

An alternative option would be to make the codeclimate secret available
to everyone, but that's not very safe.

Fixes #619
@trotzig trotzig mentioned this issue Feb 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trotzig trotzig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable codeclimate when env var is missing Galooshi/import-js
2 participants
@trotzig @mikabytes