-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken deployment due to pytest-cov #106
Comments
Hi @StefanoCretti , Thank you for using coolbox. I'm sorry I currently don't have time to fix the issues in the project. Don't worry about the spam issue; if your PR is ready, you can remind me to merge it at any time. |
Hey, after a couple of attempts, it seems like I have gotten CI working. What I did was:
I put these changes together with a bugfix in track height computation. All of these are in PR #105. @Nanguage, if everything looks good to you it can be merged. |
Despite all tests running correctly in PR #105, CI still fails upon merge due to codecov. The problem seems to be similar to the one in this issue. I could try to fix codecov, but I do not really feel like going down this rabbit hole. Since having the codecov badge does not really benefit the project anyway, how would you feel about dropping the codecov action altogether, @Nanguage? |
Sure I agree, we can cancel codecov. |
I have removed the code cov |
Thank you so much for your cooperation. One last thing and then I will stop nagging you (at least for a long while): the current GitHub actions do not deploy on conda (they just test the package). Would it trouble you to create a release with all the new changes? If you do not feel like doing it manually I can help with setting up the deployment to conda via actions, but that would still require some work from you (I think you would need to set up the authentication tokens, though I have never done it so I am not sure). |
Sorry, Caused inconvenience to you and other users. This things is what I should do. I will try to deploy to conda again. Additionally, if you are willing, I can give you maintainer permissions so that you can directly modify the repo. This may make our cooperation easier. Thank you again. |
@Nanguage thank you for addressing this so fast. With the last release, all I need for my current project should be already in place, so I do not foresee myself working on this much in the near future (though I might be wrong). Still, I would not mind helping with maintaining coolbox and solving some issues from time to time, since it helped me save quite a lot of time. Also, closing issue since everything was fixed and shipped in version 0.3.9 |
Ok, thank you! |
Judging from the error stack, conda deployment seems to break due to pytest-cov trying to use a mismatched version of sqlite3/libsqlite. The error seems similar to this, so I assume that forcing pytest-cov installation from conda-forge channel could solve the issue.
I would love for the deployment to be fixed, since I use coolbox as dependency for a project of mine and installing through git can be annoying with some package managers.
I can try doing it myself if you do not have the time, though I have never tried fixing GitHub actions so it might lead to a bit of PR submit/delete spam while I try to figure it out.
The text was updated successfully, but these errors were encountered: