Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Die shade issue #11

Open
0xtceb opened this issue Jun 27, 2022 · 3 comments
Open

Die shade issue #11

0xtceb opened this issue Jun 27, 2022 · 3 comments

Comments

@0xtceb
Copy link

0xtceb commented Jun 27, 2022

const shadeDie = tf.fill([12, 12], 1 - x)

Aren't you creating a new rank 2 Tensor filled with 1 everywhere instead of copying and shading an existing dice ?

@GantMan
Copy link
Owner

GantMan commented Jun 28, 2022

Correct. I believe this was to handle shades of gray from white to black. However, I agree, it might be better to shade actual dice. If you get better results, please share. I strongly believe the dice example could be significantly improved, but I didn't want to get too advanced too fast.

@0xtceb
Copy link
Author

0xtceb commented Jun 29, 2022

Your book was great to read and experiment with, arrived at this test I could not understand the purpose of shading X times out of X times the same values and what was the benefits for the training datas. If i got to this level of understanding you can blame your book for it ;) .

@GantMan
Copy link
Owner

GantMan commented Jun 30, 2022

Bwahahahaha I def do blame the book <3

Generating training data is an art form. You should see how many cool generated datasets are out there. I do want to come back to this dice code one day and improve it. I feel like I 2x the quality of the results if I wanted to. Maybe one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants