-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Die shade issue #11
Comments
Correct. I believe this was to handle shades of gray from white to black. However, I agree, it might be better to shade actual dice. If you get better results, please share. I strongly believe the dice example could be significantly improved, but I didn't want to get too advanced too fast. |
Your book was great to read and experiment with, arrived at this test I could not understand the purpose of shading X times out of X times the same values and what was the benefits for the training datas. If i got to this level of understanding you can blame your book for it ;) . |
Bwahahahaha I def do blame the book <3 Generating training data is an art form. You should see how many cool generated datasets are out there. I do want to come back to this dice code one day and improve it. I feel like I 2x the quality of the results if I wanted to. Maybe one day. |
learn-tfjs/chapter12/node/node-dice-data/src/index.js
Line 60 in 0c0dbc8
Aren't you creating a new rank 2 Tensor filled with 1 everywhere instead of copying and shading an existing dice ?
The text was updated successfully, but these errors were encountered: