Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date/time formatting output #440

Closed
mauteri opened this issue Dec 8, 2023 · 5 comments · Fixed by #517
Closed

Fix date/time formatting output #440

mauteri opened this issue Dec 8, 2023 · 5 comments · Fixed by #517
Assignees

Comments

@mauteri
Copy link
Contributor

mauteri commented Dec 8, 2023

Add Date Format and Time Format for date & time output in GatherPress under GatherPress general settings.

@mauteri mauteri converted this from a draft issue Dec 8, 2023
@mauteri mauteri self-assigned this Dec 14, 2023
@mauteri mauteri moved this from Next Release to QA Review in GatherPress Project Dec 14, 2023
@patriciabt
Copy link
Collaborator

patriciabt commented Dec 15, 2023

Tested with your latest build.

In settings: all good.
In events: still displays the default date/time format

2023-12-15_09-54-54

2023-12-15_09-56-25

@patriciabt
Copy link
Collaborator

Got something here, after talking about it with @mauteri (as it also happens for standard posts!)
The date time format here follows the format entered in the template, and not the one set in general or GatherPress settings because it's a FSE theme!
And this is something I'll ask to the Gutenberg project!

@patriciabt
Copy link
Collaborator

patriciabt commented Jan 27, 2024

I was wrong in the previous comment and this above is solved.

But there is another place where the datetime format output is wrong, it's in the event block when we add it to any content
image

where it's correct now the output in the event single, or in the page listing events
image

@mauteri
Copy link
Contributor Author

mauteri commented Jan 27, 2024

This is at the block level, so I'm going to put this configuration into the block itself as a setting.

@mauteri mauteri moved this from QA Review to In Progress in GatherPress Project Jan 27, 2024
@mauteri
Copy link
Contributor Author

mauteri commented Jan 27, 2024

PR for this #517

@github-project-automation github-project-automation bot moved this from In Progress to Done in GatherPress Project Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants