Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Docker image for the project #38

Open
noorbuchi opened this issue Mar 1, 2021 · 4 comments · May be fixed by #80
Open

Creating a Docker image for the project #38

noorbuchi opened this issue Mar 1, 2021 · 4 comments · May be fixed by #80
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request Team 5 (Andre, Bailey, Thomas, Bennet)

Comments

@noorbuchi
Copy link
Collaborator

Running this tool locally can be difficult in some instances. It has many dependencies that need to be installed through various commands like pip install pipenv and pipenv install in addition to installing the Spacy models.

This hassle can be avoided for the user by simply using a Docker image to create and run a container. Instead of ensuring that the Python environment has all the dependencies, the user can run the tool simply by downloading the image and then running it with a docker run command. This feature would also make it easier to host this tool on a cloud platform to potentially be accessed easily. This feature should build on what #31 discusses. Specifically, the pip install command can be run inside the container to get all the needed files.

Useful resources:
Docker overview
Using Docker and examples

@noorbuchi noorbuchi added the enhancement New feature or request label Mar 1, 2021
@ahance27 ahance27 added the Team 5 (Andre, Bailey, Thomas, Bennet) label Mar 22, 2021
@antlet
Copy link
Collaborator

antlet commented Mar 24, 2021

Team 5 has started working on this issue.

@antlet antlet added the documentation Improvements or additions to documentation label Mar 24, 2021
@noorbuchi
Copy link
Collaborator Author

@antlet Thanks for working on this issue! Please let me know if I can help.

@BennyWestsyde
Copy link
Collaborator

@noorbuchi Team 5 has almost finished the issue, the only problem is that sometimes the docker image fails on build. It should be 2.02 Gigabytes after the build, however, it sometimes only builds to 1.96 Gigabytes and then won't properly execute because it is missing Gensim. I have found a possible fix though. If I build it on my docker and then push it to docker hub it won't need to be built by users. My only issue with this is that it would be run under the name bennywestsyde/gatorminer. Do you know if there is a docker account or organization I can join so that my username isn't directly attached to it?

@noorbuchi
Copy link
Collaborator Author

noorbuchi commented Apr 5, 2021

@BennyWestsyde That's an interesting issue. I'll be taking a look at it and I'll let you know how we can solve it. Which branch is this team currently working on. I can see that there are two branches with Docker in their title. If one of them is not being used, I think it's safe to delete it.

@antlet antlet linked a pull request Apr 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Team 5 (Andre, Bailey, Thomas, Bennet)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants