From 60b9f13ec27ab7f15d2ad7b1a5c36ef1dac2181e Mon Sep 17 00:00:00 2001 From: Gatsik <74517072+Gatsik@users.noreply.github.com> Date: Wed, 8 Jan 2025 12:43:04 +0200 Subject: [PATCH] Disable locked achivements' icons and improve var name in group_achievements method --- src/playercard/achievements.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/playercard/achievements.py b/src/playercard/achievements.py index dfcab1740..bff11e2f2 100644 --- a/src/playercard/achievements.py +++ b/src/playercard/achievements.py @@ -80,6 +80,7 @@ def icon(self, icon_name: str = "") -> QPixmap: def set_icon(self, pixmap: QPixmap) -> None: self.iconLabel.setPixmap(pixmap) + self.iconLabel.setEnabled(self.player_achievement.current_state == State.UNLOCKED) def on_icon_downloaded(self, _: str, pixmap: QPixmap) -> None: self.set_icon(pixmap) @@ -156,9 +157,9 @@ def group_achievements( self, player_achievements: Iterator[PlayerAchievement], ) -> AchievementGroup: - unlocked, locked, included_ids = [], [], [] + unlocked, locked, progressed_any_percent = [], [], [] for player_achievement in player_achievements: - included_ids.append(player_achievement.achievement.xd) + progressed_any_percent.append(player_achievement.achievement.xd) if player_achievement.current_state == State.UNLOCKED: unlocked.append(player_achievement) else: @@ -166,7 +167,7 @@ def group_achievements( locked.extend(( self.mock_player_achievement(entry) for entry in self.all_achievements - if entry.xd not in included_ids + if entry.xd not in progressed_any_percent )) return AchievementGroup(locked, unlocked)