Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preloading *-image-set fails #147

Closed
tomasvanrijsse opened this issue Sep 29, 2015 · 2 comments
Closed

Preloading *-image-set fails #147

tomasvanrijsse opened this issue Sep 29, 2015 · 2 comments
Labels

Comments

@tomasvanrijsse
Copy link

We've implemented the *-image-set for a website but the QueryLoader tries to preload these images incorrect.
Our html looks a bit like this:

<div style="
  background-image: url(media/1.jpg);
  background-image: -webkit-image-set( url(media/1.jpg) 1x, url(media/[email protected]) 2x );
"></div>

This piece of HTML results into the GET requests for

http://domain.com/-webkit-image-set(http://domain.com/media/1.jpg%201x
http://domain.com/media/[email protected]%202x

It appears the QueryLoader doesn't interpret the *-image-set and therefore simply tries to create an url for the whole string.

@Gaya
Copy link
Owner

Gaya commented Sep 30, 2015

Thanks for letting me know. I will take a look shortly.

@Gaya Gaya added the bug label Sep 30, 2015
@Gaya
Copy link
Owner

Gaya commented Sep 30, 2015

Already opened in #118. Will reference this issue as extra information, but will close this issue.

@Gaya Gaya closed this as completed Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants