You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
no events are emitted in the contract-register or the marketconfiugurator in v3.1 for addpool or addcreditmanager. for pools, i can use createmarket event, so addpool is not needed. But for creditmanager no event is emitted. Emit CreateCreditManager(creditmanager) event in deployCreditManager atlteast.
trusted param is of no use in setPriceFeedFromStore in marketconfigurator? explanation needed.
In the newPriceOraclev3.sol, we don’t maintain useReserve field. We emit setPriceFeed if the price feed is main, and setReservePriceFeed if the price feed is reserve. Since there is no useReserve we can’t switch btw the price feed so how can we use reserve price when needed? and SetReservePriceFeedStatus is also removed. so how to we switch btw them.
in changePriceOracle priceoracle[pool] is not updated to new address and u should emit SetPriceOracle(pool, priceoracle) event. This event should also be emitted in createmarket.
The text was updated successfully, but these errors were encountered:
no events are emitted in the contract-register or the marketconfiugurator in v3.1 for addpool or addcreditmanager. for pools, i can use
createmarket
event, so addpool is not needed. But for creditmanager no event is emitted. EmitCreateCreditManager(creditmanager)
event in deployCreditManager atlteast.trusted
param is of no use insetPriceFeedFromStore
in marketconfigurator? explanation needed.In the newPriceOraclev3.sol, we don’t maintain useReserve field. We emit setPriceFeed if the price feed is main, and setReservePriceFeed if the price feed is reserve. Since there is no useReserve we can’t switch btw the price feed so how can we use reserve price when needed? and SetReservePriceFeedStatus is also removed. so how to we switch btw them.
in changePriceOracle
priceoracle[pool]
is not updated to new address and u should emitSetPriceOracle(pool, priceoracle)
event. This event should also be emitted increatemarket
.The text was updated successfully, but these errors were encountered: