Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs/ missing events #10

Open
harsh-98 opened this issue Oct 5, 2024 · 0 comments
Open

Bugs/ missing events #10

harsh-98 opened this issue Oct 5, 2024 · 0 comments

Comments

@harsh-98
Copy link
Collaborator

harsh-98 commented Oct 5, 2024

  • no events are emitted in the contract-register or the marketconfiugurator in v3.1 for addpool or addcreditmanager. for pools, i can use createmarket event, so addpool is not needed. But for creditmanager no event is emitted. Emit CreateCreditManager(creditmanager) event in deployCreditManager atlteast.

  • trusted param is of no use in setPriceFeedFromStore in marketconfigurator? explanation needed.

  • In the newPriceOraclev3.sol, we don’t maintain useReserve field. We emit setPriceFeed if the price feed is main, and setReservePriceFeed if the price feed is reserve. Since there is no useReserve we can’t switch btw the price feed so how can we use reserve price when needed? and SetReservePriceFeedStatus is also removed. so how to we switch btw them.

  • in changePriceOracle priceoracle[pool] is not updated to new address and u should emit SetPriceOracle(pool, priceoracle) event. This event should also be emitted in createmarket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant