Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new.block< old.block for zero price feed. #84

Open
harsh-98 opened this issue Feb 26, 2024 · 0 comments
Open

new.block< old.block for zero price feed. #84

harsh-98 opened this issue Feb 26, 2024 · 0 comments

Comments

@harsh-98
Copy link
Collaborator

when for a token price feed is changed to zero price feed, Price for that token is added while syncing priceOracle. as a result, zero priceFeed is added first, and price events from previous pricefeed are yet to be synced. So, check (old.block< new.block) fails.
Solution:
Ignore this check if the saved price event has 0 price. In such case, last price block number can be greater than new price event being added.

a0db78c fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant