Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MISC]: Drop vendored tomli import when support for 3.10 is dropped #73

Open
1 task done
teald opened this issue Nov 26, 2024 · 0 comments
Open
1 task done

[MISC]: Drop vendored tomli import when support for 3.10 is dropped #73

teald opened this issue Nov 26, 2024 · 0 comments
Assignees
@teald
Labels
CI/CD Changes to CI/CD workflows dependencies Pull requests that update a dependency file maintenance For maintenance tasks misc Miscellaneous (not covered by other tags)

Comments

@teald
Copy link
Member

teald commented Nov 26, 2024 •
edited
Loading

Contact Details

No response

What happened?

Summary

In our nox automations, we use tomllib in python >= 3.11 to parse the pyproject.toml file and get dependency groups. Instead of injecting a temporary tomli or equivalent dependency to support 3.10, PR #72 used some conditional imports and pip's vendored tomli version.

This is an unstable hack, really only meant to survive until we drop support for Python 3.10 soon.1

Code of Conduct

  • I agree to follow this project's Code of Conduct

Footnotes

  1. For more information, see SPEC 0, which we use as guidance for what python versions we support. ↩
@teald teald added dependencies Pull requests that update a dependency file maintenance For maintenance tasks CI/CD Changes to CI/CD workflows misc Miscellaneous (not covered by other tags) labels Nov 26, 2024
@teald teald self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teald teald

Labels
CI/CD Changes to CI/CD workflows dependencies Pull requests that update a dependency file maintenance For maintenance tasks misc Miscellaneous (not covered by other tags)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teald